Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): REST methods in dart with auth mode none #1783

Merged
merged 36 commits into from
Jun 27, 2022
Merged

feat(api): REST methods in dart with auth mode none #1783

merged 36 commits into from
Jun 27, 2022

Conversation

ragingsquirrel3
Copy link
Contributor

@ragingsquirrel3 ragingsquirrel3 commented Jun 21, 2022

Initial implementation of REST API methods (get(), post(), etc...) with no authorization (auth mode = "NONE"). There was an earlier version of this PR which I closed and remade into this one after some feedback made me refactor.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ragingsquirrel3 ragingsquirrel3 marked this pull request as ready for review June 21, 2022 20:11
@ragingsquirrel3 ragingsquirrel3 requested a review from a team as a code owner June 21, 2022 20:11
Copy link
Contributor

@dnys1 dnys1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Member

@Jordan-Nelson Jordan-Nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I left a couple nit comments. I think this should be good to go after a couple of Dillons comments are addressed.

packages/api/amplify_api/lib/src/amplify_api_config.dart Outdated Show resolved Hide resolved
packages/api/amplify_api/lib/src/util.dart Outdated Show resolved Hide resolved
packages/api/amplify_api/lib/src/util.dart Outdated Show resolved Hide resolved
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
@ragingsquirrel3 ragingsquirrel3 merged commit d4c5dd5 into aws-amplify:feat/api-next Jun 27, 2022
@ragingsquirrel3 ragingsquirrel3 deleted the feat/api-rest2 branch June 27, 2022 22:28
HuiSF pushed a commit to HuiSF/amplify-flutter that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants