-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): REST methods in dart with auth mode none #1783
Merged
ragingsquirrel3
merged 36 commits into
aws-amplify:feat/api-next
from
ragingsquirrel3:feat/api-rest2
Jun 27, 2022
Merged
feat(api): REST methods in dart with auth mode none #1783
ragingsquirrel3
merged 36 commits into
aws-amplify:feat/api-next
from
ragingsquirrel3:feat/api-rest2
Jun 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jordan Nelson <Jordan.Ryan.Nelson@gmail.com>
dnys1
reviewed
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
packages/api/amplify_api/lib/src/amplify_authorization_rest_client.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I left a couple nit comments. I think this should be good to go after a couple of Dillons comments are addressed.
Jordan-Nelson
approved these changes
Jun 27, 2022
dnys1
approved these changes
Jun 27, 2022
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
ragingsquirrel3
pushed a commit
that referenced
this pull request
Jul 21, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 16, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 23, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 9, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 14, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 15, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 26, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Oct 19, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 8, 2022
HuiSF
pushed a commit
to HuiSF/amplify-flutter
that referenced
this pull request
Nov 10, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of REST API methods (get(), post(), etc...) with no authorization (auth mode = "NONE"). There was an earlier version of this PR which I closed and remade into this one after some feedback made me refactor.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.