fix(amplify_authenticator): authenticator phone OR email confirmation #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
commented
Jun 21, 2022
| @@ -178,9 +178,9 @@ Future<void> adminCreateUser( | |||
| } | |||
| } | |||
|
|
|||
| /// Returns the OTP code for [username]. Must be called before the network call | |||
| /// Returns the OTP code for [email]. Must be called before the network call | |||
There was a problem hiding this comment.
Note: The lambdas (for "email" auth and "email OR phone" auth) are set up to use the email address, regardless of what is being used for a "username".
This didn't have to change, but the new tests I added where phone number is the username were a bit confusing to read without the change.
dnys1
previously approved these changes
Jun 21, 2022
| // Reset current username value to align with the current switch state. | ||
| String newUsername = useEmail | ||
| String newUsername = newUsernameSelection == |
There was a problem hiding this comment.
Suggested change
| String newUsername = newUsernameSelection == | |
| final newUsername = newUsernameSelection == |
Comment on lines
68
to
70
| SignUpPage signUpPage = SignUpPage(tester: tester); | ||
| ConfirmSignUpPage confirmSignUpPage = ConfirmSignUpPage(tester: tester); | ||
| SignInPage signInPage = SignInPage(tester: tester); |
There was a problem hiding this comment.
Suggested change
| SignUpPage signUpPage = SignUpPage(tester: tester); | |
| ConfirmSignUpPage confirmSignUpPage = ConfirmSignUpPage(tester: tester); | |
| SignInPage signInPage = SignInPage(tester: tester); | |
| final signUpPage = SignUpPage(tester: tester); | |
| final confirmSignUpPage = ConfirmSignUpPage(tester: tester); | |
| final signInPage = SignInPage(tester: tester); |
Comment on lines
118
to
120
| SignUpPage signUpPage = SignUpPage(tester: tester); | ||
| ConfirmSignUpPage confirmSignUpPage = ConfirmSignUpPage(tester: tester); | ||
| SignInPage signInPage = SignInPage(tester: tester); |
There was a problem hiding this comment.
Suggested change
| SignUpPage signUpPage = SignUpPage(tester: tester); | |
| ConfirmSignUpPage confirmSignUpPage = ConfirmSignUpPage(tester: tester); | |
| SignInPage signInPage = SignInPage(tester: tester); | |
| final signUpPage = SignUpPage(tester: tester); | |
| final confirmSignUpPage = ConfirmSignUpPage(tester: tester); | |
| final signInPage = SignInPage(tester: tester); |
| // Then I see "Sign out" | ||
| await signInPage.expectAuthenticated(); | ||
| }, | ||
| skip: !isMobile, |
| // Reset current username value to align with the current switch state. | ||
| String newUsername = useEmail | ||
| String newUsername = newUsernameSelection == | ||
| UsernameSelection.email | ||
| ? state.getAttribute(CognitoUserAttributeKey.email) ?? '' | ||
| : state.getAttribute( | ||
| CognitoUserAttributeKey.phoneNumber) ?? | ||
| ''; | ||
| state.username = newUsername; |
There was a problem hiding this comment.
Since .username and .usernameSelection both trigger rebuilds, I think setting the username first might make more sense?
packages/amplify_authenticator/lib/src/mixins/authenticator_username_field.dart
Show resolved
Hide resolved
haverchuck
previously approved these changes
Jun 21, 2022
dnys1
approved these changes
Jun 22, 2022
haverchuck
approved these changes
Jun 22, 2022
Jordan-Nelson
deleted the
fix/main/authenticator-phone-number-confirmation
branch
9 tasks
Jordan-Nelson
added a commit
to Jordan-Nelson/amplify-flutter
that referenced
this pull request
Jun 22, 2022
…aws-amplify#1785) * fix(authenticator): move username selection state to authenticator state * chore; update imports * test: add integration tests for email or phone configs * chore: move username input enum
Jordan-Nelson
added a commit
to Jordan-Nelson/amplify-flutter
that referenced
this pull request
Jun 28, 2022
…aws-amplify#1785) * fix(authenticator): move username selection state to authenticator state * chore; update imports * test: add integration tests for email or phone configs * chore: move username input enum
Jordan-Nelson
added a commit
that referenced
this pull request
Jun 29, 2022
…#1785) * fix(authenticator): move username selection state to authenticator state * chore; update imports * test: add integration tests for email or phone configs * chore: move username input enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.