chore(api): API Pigeon update #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
reviewed
Jun 24, 2022
There was a problem hiding this comment.
Looks good! You'll need to make some changes to the API podspec to declare support for async/await, which was released for iOS 15 and then backported to iOS 13 in Xcode 13.2/Swift 5.5.
Since vNext will have a minimum iOS target of 13.0, this works out great for us, we just need to make sure the end-user is using Swift 5.5 so that it compiles properly. Here's how to do that: https://github.com/aws-amplify/amplify-flutter/blob/next/packages/auth/amplify_auth_cognito_ios/ios/amplify_auth_cognito_ios.podspec#L23
Jordan-Nelson
approved these changes
Jun 27, 2022
Equartey
added a commit
that referenced
this pull request
Jun 27, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Jul 21, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 16, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 23, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 9, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 14, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 15, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 26, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Oct 19, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 8, 2022
HuiSF
pushed a commit
to HuiSF/amplify-flutter
that referenced
this pull request
Nov 10, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.