feat!(core,auth): auth providers definition and CognitoIamAuthProvider registers in Auth #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jordan Nelson <Jordan.Ryan.Nelson@gmail.com>
ragingsquirrel3
changed the title
ragingsquirrel3
commented
Jul 18, 2022
|
|
||
| /// A hardcoded key which can provide throttling for an unauthenticated API. | ||
| /// | ||
| /// See also: | ||
| /// - [API Key Authorization](https://docs.aws.amazon.com/appsync/latest/devguide/security-authz.html#api-key-authorization) | ||
| @JsonValue('API_KEY') | ||
| apiKey, | ||
| apiKey(AmplifyAuthProviderToken<AmplifyAuthProvider>()), |
There was a problem hiding this comment.
I think this will have a different auth provider type for api key, but plan to do in PR where I integrate in API plugin w api key.
dnys1
approved these changes
Jul 18, 2022
packages/auth/amplify_auth_cognito_dart/test/plugin/auth_providers_test.dart
Outdated
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito_dart/test/plugin/auth_providers_test.dart
Outdated
Show resolved
Hide resolved
…ders_test.dart Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
…ders_test.dart Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
haverchuck
reviewed
Jul 19, 2022
packages/auth/amplify_auth_cognito_dart/lib/src/auth_plugin_impl.dart
Outdated
Show resolved
Hide resolved
haverchuck
approved these changes
Jul 19, 2022
…pl.dart Co-authored-by: Dustin Noyes <dustin.noyes.dev@gmail.com>
HuiSF
approved these changes
Jul 19, 2022
| @@ -16,6 +16,7 @@ import 'dart:convert'; | |||
|
|
|||
| import 'package:amplify_flutter/amplify_flutter.dart'; | |||
| import 'package:amplify_flutter/src/amplify_impl.dart'; | |||
| import 'package:flutter/material.dart'; | |||
There was a problem hiding this comment.
Why do we need the material library here? It provides only the UI widgets correct?
There was a problem hiding this comment.
good catch, removed. I think it was left from a previous implementation that used describeEnum.
| abstract class AmplifyAuthProvider { | ||
| Future<AWSBaseHttpRequest> authorizeRequest( | ||
| AWSBaseHttpRequest request, { | ||
| covariant AuthProviderOptions? options, |
There was a problem hiding this comment.
Good to know about covariant, it should help us to avoid type casting required on consumer side like this?
final result = await Amplify.Auth.fetchAuthSession(
options: CognitoSessionOptions(getAWSCredentials: true),
);
String identityId = (result as CognitoAuthSession).identityId!;There was a problem hiding this comment.
Maybe I'm missing this, but don't think it helps here and casting would still be needed as I think it can only be used for parameters, not return types.
Separately, I think we will be able to define an auth provider that can provide identity IDs so casting would not be needed outside auth plugin for this use case.
added 2 commits
July 19, 2022 09:02
…tter into feat/api-iam
ragingsquirrel3
pushed a commit
that referenced
this pull request
Jul 21, 2022
…r registers in Auth (#1851)
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 16, 2022
…r registers in Auth (#1851)
HuiSF
pushed a commit
to HuiSF/amplify-flutter
that referenced
this pull request
Aug 22, 2022
…r registers in Auth (aws-amplify#1851)
HuiSF
pushed a commit
to HuiSF/amplify-flutter
that referenced
this pull request
Aug 23, 2022
…r registers in Auth (aws-amplify#1851)
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 23, 2022
…r registers in Auth (#1851)
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 9, 2022
…r registers in Auth (#1851)
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 14, 2022
…r registers in Auth (#1851)
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 15, 2022
…r registers in Auth (#1851)
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 26, 2022
…r registers in Auth (#1851)
dnys1
pushed a commit
to dnys1/amplify-flutter
that referenced
this pull request
Oct 3, 2022
…r registers in Auth (aws-amplify#1851) commit-id:332d00d5
ragingsquirrel3
pushed a commit
that referenced
this pull request
Oct 19, 2022
…r registers in Auth (#1851)
dnys1
pushed a commit
that referenced
this pull request
Oct 21, 2022
…r registers in Auth (#1851) commit-id:332d00d5
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 8, 2022
…r registers in Auth (#1851)
HuiSF
pushed a commit
to HuiSF/amplify-flutter
that referenced
this pull request
Nov 10, 2022
…r registers in Auth (aws-amplify#1851)
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 10, 2022
…r registers in Auth (#1851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the initial implementation in core of auth providers, related changes to plugin configuration signature and auth plugin registers the first auth provider. In another PR, I plan to integrate this with API plugin to support IAM auth mode but this PR is intentionally downscoped to just upstream logic to register the auth provider.
In summary, the auth providers are a way for other plugins to call the auth plugin indirectly. By registering an auth provider from auth plugin, other plugins essentially get a callback they can use to call auth methods as long as auth is registered at runtime and other plugins don't need an auth dependency or to call
Amplify.Auth...directly. This avoids compile-time errors.BREAKING CHANGE: configure method for plugins now requires an instance of auth provider repo. This change is only breaking for plugin authors, not plugin users.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.