Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): delete test fix #1880

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix(datastore): delete test fix #1880

merged 1 commit into from
Jul 13, 2022

Conversation

haverchuck
Copy link
Contributor

Description of changes:
Fixes datastore delete test by expecting a DatastoreException on non-matching predicate failure.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haverchuck haverchuck requested a review from a team as a code owner July 13, 2022 18:05
Copy link
Member

@HuiSF HuiSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

Copy link
Contributor

@ragingsquirrel3 ragingsquirrel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@haverchuck haverchuck merged commit 594e658 into main Jul 13, 2022
haverchuck added a commit that referenced this pull request Jul 13, 2022
haverchuck added a commit that referenced this pull request Jul 14, 2022
@dnys1 dnys1 deleted the fix/datastore-delete-test branch March 30, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants