Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Emit errors/stack traces in logger #1897

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Jul 20, 2022

Before

flutter: ERROR | SignUpStateMachine | Emitted error
flutter: ERROR | Authenticator | Error in AuthBloc

After

flutter: ERROR | SignUpStateMachine | Emitted error: InvalidParameterException [Attributes did not conform to the schema: email: The attribute is required, null, null]
#0      HttpOperation.deserializeOutput
package:smithy/…/http/http_operation.dart:278
<asynchronous suspension>
#1      AWSRetryer.retry
package:smithy_aws/…/retry/aws_retryer.dart:160
<asynchronous suspension>
#2      WrappedCognitoIdentityProviderClient.signUp
package:amplify_auth_cognito_dart/…/sdk/sdk_bridge.dart:516
<asynchronous suspension>
#3      SignUpStateMachine.onInitiate
package:amplify_auth_cognito_dart/…/machines/sign_up_state_machine.dart:42
<asynchronous suspension>
#4      SignUpStateMachineBase.resolve
package:amplify_auth_cognito_dart/…/generated/sign_up_state_machine_base.dart:39
<asynchronous suspension>
#5      StateMachine._listenForEvents
package:amplify_core/…/state_machine/state_machine.dart:171
<asynchronous suspension>
flutter: ERROR | Authenticator | Error in AuthBloc: InvalidParameterException [Attributes did not conform to the schema: email: The attribute is required, null, null]

@dnys1 dnys1 requested a review from a team as a code owner July 20, 2022 00:51
@codecov-commenter
Copy link

Codecov Report

Merging #1897 (e99abe0) into next (cba3bc3) will increase coverage by 6.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #1897      +/-   ##
==========================================
+ Coverage   27.92%   34.89%   +6.97%     
==========================================
  Files         106      111       +5     
  Lines        5522     6376     +854     
==========================================
+ Hits         1542     2225     +683     
- Misses       3980     4151     +171     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 26.86% <ø> (ø)
ios-unit-tests 80.20% <ø> (-1.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._ios/example/ios/unit_tests/RestApiUnitTests.swift 85.16% <0.00%> (ø)
..._pinpoint_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...plify_api_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...xample/ios/unit_tests/FlutterURLSessionTests.swift 58.49% <0.00%> (ø)
...s/example/ios/unit_tests/GraphQLApiUnitTests.swift 89.50% <0.00%> (ø)

@dnys1 dnys1 merged commit d436a1e into aws-amplify:next Jul 22, 2022
@dnys1 dnys1 deleted the chore/logger/emit-errors branch July 22, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants