feat(auth,api): cognito user pools auth provider & auth mode for API HTTP requests #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragingsquirrel3
commented
Jul 21, 2022
| @@ -64,8 +64,15 @@ Future<http.BaseRequest> authorizeHttpRequest(http.BaseRequest request, | |||
| return authorizedRequest.httpRequest; | |||
| case APIAuthorizationType.function: | |||
| case APIAuthorizationType.oidc: | |||
| case APIAuthorizationType.userPools: | |||
| throw UnimplementedError('${authType.name} not implemented.'); | |||
There was a problem hiding this comment.
I haven't tested with OIDC/lambda, but I'm thinking when we register the API auth providers from API plugin instantiation with the auth provider repo which define different way to get token, we can just remove this line here and this part should work with those providers.
ragingsquirrel3
changed the title
Codecov Report
@@ Coverage Diff @@
## feat/api-next #1913 +/- ##
=================================================
+ Coverage 45.14% 45.17% +0.02%
=================================================
Files 130 130
Lines 7713 7717 +4
=================================================
+ Hits 3482 3486 +4
Misses 4231 4231
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dnys1
reviewed
Jul 22, 2022
packages/auth/amplify_auth_cognito_dart/lib/src/util/cognito_user_pools_auth_provider.dart
Outdated
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito_dart/test/plugin/auth_providers_test.dart
Show resolved
Hide resolved
Equartey
approved these changes
Jul 26, 2022
dnys1
approved these changes
Jul 28, 2022
packages/auth/amplify_auth_cognito_dart/test/plugin/auth_providers_test.dart
Show resolved
Hide resolved
packages/auth/amplify_auth_cognito_dart/test/plugin/auth_providers_test.dart
Show resolved
Hide resolved
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 16, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Aug 23, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 9, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 14, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 15, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Sep 26, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Oct 19, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 8, 2022
HuiSF
pushed a commit
to HuiSF/amplify-flutter
that referenced
this pull request
Nov 10, 2022
ragingsquirrel3
pushed a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables cognito user pools auth mode in HTTP requests for API category, thus enabling REST and query/mutate in GraphQL. It does so by defining an auth provider in the auth plugin that provides the access token as a header to HTTP requests. In API plugin, that auth provider is used to authorize HTTP requests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.