fix(storage): Download to existing file #2116
Conversation
dnys1
force-pushed
the
chore/storage/integ-tests
branch
from
50b02d6 to
48f743c
Compare
| // Delete the file if it already exists since iOS will only write to | ||
| // a non-existent file; it will not overwrite the contents of an existing | ||
| // one. | ||
| if (Platform.isIOS && await request.local.exists()) { | ||
| await request.local.delete(); | ||
| } |
There was a problem hiding this comment.
This is the actual fix. The rest is updating tests and Xcode files.
There was a problem hiding this comment.
If the download fails this will result in the original file being deleted without the new file being downloaded. Is that expected? Should this instead write to a temp directory and then copy it over?
There was a problem hiding this comment.
Since the intention is to overwrite whatever is passed in, then I think this is probably fine, although to be safe I can update it 👍
|
Thanks for fixing this issue! amplify-android implements the logic if file exists (1.x, 2.x), it deletes the original file before write the new file. IMO, we should also file an issue to amplify-ios to implement the same logic instead of fixing in amplify-flutter (we may merge this PR as a temporary fix?). This behavior should be consistent cross Amplify platform libraries. |
dnys1
force-pushed
the
chore/storage/integ-tests
branch
from
93dca63 to
81c1acd
Compare
Fixes aws-amplify#2105. Fixes an issue where downloading to an existing file will not work on iOS. For whatever reason, it will report progress and success, but will ultimately not overwrite the contents of the file. commit-id:157d4ea3
commit-id:fa7c4c42
First downloads to a non-existent file, then copies the file to the location of the original in order to avoid iOS restrictions on overwriting data and potential failures which would result in deletion of the original file. commit-id:7fbfb559
dnys1
force-pushed
the
chore/storage/integ-tests
branch
from
81c1acd to
355dc65
Compare
Fixes #2105.
Fixes an issue where downloading to an existing file will not work on iOS. For whatever reason, it will report progress and success, but will ultimately not overwrite the contents of the file.