fix(storage): Custom Prefix Android #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2142 +/- ##
==========================================
+ Coverage 45.94% 46.23% +0.28%
==========================================
Files 359 364 +5
Lines 10871 10977 +106
==========================================
+ Hits 4995 5075 +80
- Misses 5876 5902 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dnys1
reviewed
Sep 20, 2022
packages/storage/amplify_storage_s3/lib/method_channel_storage_s3.dart
Outdated
Show resolved
Hide resolved
fjnoyp
force-pushed
the
fix/storage_custom_prefix_android_fix
branch
2 times, most recently
from
44d9d32 to
73c95a9
Compare
Add missing case for public -> guest Fix warnings in iOS
…_s3.dart Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
fjnoyp
force-pushed
the
fix/storage_custom_prefix_android_fix
branch
2 times, most recently
from
7f74577 to
6535662
Compare
dnys1
approved these changes
Oct 5, 2022
HuiSF
approved these changes
Oct 10, 2022
Merged
ragingsquirrel3
pushed a commit
that referenced
this pull request
Oct 12, 2022
* fix(storage): Custom Prefix Android Add missing case for public -> guest Fix warnings in iOS * Update packages/storage/amplify_storage_s3/lib/method_channel_storage_s3.dart Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing case for public -> guest
Fix warnings in iOS
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.