chore(datastore): run integ tests in CI #2182
Conversation
| with: | ||
| # API levels 30+ too slow https://github.com/ReactiveCircus/android-emulator-runner/issues/222 | ||
| api-level: 29 | ||
| script: melos exec -c 1 --scope ${{ matrix.scope }} -- "deviceId=emulator-5554 retries=1 \$MELOS_ROOT_PATH/build-support/integ_test_android.sh" | ||
| script: melos exec -c 1 --scope ${{ matrix.scope }} -- "deviceId=emulator-5554 retries=1 small=true \$MELOS_ROOT_PATH/build-support/integ_test_android.sh" |
There was a problem hiding this comment.
Could we make use of tags instead of the small/large flag?
There was a problem hiding this comment.
Looked into this and had some issues, will ping you offline.
| @@ -104,7 +104,7 @@ void main() { | |||
| DateTime(0000, 01, 01, 00, 00, 00), | |||
| DateTime(1970, 01, 01, 00, 00, 00), | |||
| DateTime(2020, 01, 01, 00, 00, 00), | |||
| DateTime(2020, 01, 01, 23, 59, 59), | |||
| DateTime(2020, 01, 02, 23, 59, 59), | |||
There was a problem hiding this comment.
Was the test failing without this change? Might be a bug?
There was a problem hiding this comment.
Yes was failing, although not bug IMO. Discussed offline w @HuiSF but was failing consistently in CI on android/ios but not locally. These 2 values get converted to the same date and their order would get switched. Not sure why their order gets switched as I understand should return in save in order when the date equal? though not clear if that's a requirement. However, this test should just test the date order not the order when date equals.
If expected behavior is indeed that should be in some order even when the same date, there should be a separate test for that IMO, and it's a bug.
There was a problem hiding this comment.
I see. Thanks for the explanation. I thought this test was for AWSDateTime. I see it is for AWSDate. It is interesting that it was only failing in CI, but I agree there is no expectation for order in this case.
Codecov Report
@@ Coverage Diff @@
## main #2182 +/- ##
==========================================
+ Coverage 45.94% 46.24% +0.30%
==========================================
Files 359 363 +4
Lines 10871 10973 +102
==========================================
+ Hits 4995 5075 +80
- Misses 5876 5898 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -104,7 +104,7 @@ void main() { | |||
| DateTime(0000, 01, 01, 00, 00, 00), | |||
| DateTime(1970, 01, 01, 00, 00, 00), | |||
| DateTime(2020, 01, 01, 00, 00, 00), | |||
| DateTime(2020, 01, 01, 23, 59, 59), | |||
| DateTime(2020, 01, 02, 23, 59, 59), | |||
There was a problem hiding this comment.
I see. Thanks for the explanation. I thought this test was for AWSDateTime. I see it is for AWSDate. It is interesting that it was only failing in CI, but I agree there is no expectation for order in this case.
This PR enables subset of datastore integ tests in CI. In summary:
AWSDates are the same and get into different orders.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.