chore(authenticator): cherry-pick tests from main, add screen geometry tests #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add stubs for auth cognito and amplify * test: refactor tests, add tests for new configs * chore: regenerate golden files * chore: update comment, fix accidential cmd f change * chore: add license headers * chore: make internal mocks private
dnys1
approved these changes
Dec 2, 2022
Comment on lines
135
to
136
| binding.window.devicePixelRatioTestValue = ScreenGeometry.mobile.pixelRatio; | ||
| binding.window.physicalSizeTestValue = ScreenGeometry.mobile.size; |
There was a problem hiding this comment.
Why are these needed if they get overridden below?
There was a problem hiding this comment.
Good catch. I had added it because I wasn't planning on adding ScreenGeometry as one of the dimensions for the theme tests, but changed my mind and added it. Updated.
Codecov Report
@@ Coverage Diff @@
## next #2455 +/- ##
==========================================
+ Coverage 39.24% 48.90% +9.65%
==========================================
Files 107 107
Lines 6653 6654 +1
==========================================
+ Hits 2611 3254 +643
+ Misses 4042 3400 -642
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Equartey
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.