Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #30

Merged
merged 8 commits into from
Aug 16, 2020
Merged

Create CONTRIBUTING.md #30

merged 8 commits into from
Aug 16, 2020

Conversation

mlabieniec
Copy link
Contributor

@mlabieniec mlabieniec commented Aug 14, 2020

[ci skip]
Start contributing guide

Comment on lines +3 to +6
Thank you for your interest in contributing to our project! <3 Whether it's a bug report, new feature, correction, or additional documentation, we greatly value feedback and contributions from our community. Please read through these guidelines carefully before submitting a PR or issue and let us know if it's not up-to-date (or even better, submit a PR with your corrections ;)).

- [Our History and Ethos](#our-history-and-ethos)
- [Our Design](#our-design)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android & iOS do this differently.

Android does not include these sections.

I reviewed other third-party contributing guides, and they generally do not include this type of content. And also in the interest of keeping the guide brief, I omitted this content for our guide.

I suggest that all Amplify platforms move this content to an ETHOS.md or PHILOSOPHY.md. We could reference it with a one line statement from both the README.md and the CONTRIBUTING.md:

For background on Amplify's design philosophy see (external resource).

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved

@TODO

#### Packages inside Amplify JS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Packages inside Amplify JS
#### Packages inside Amplify Flutter

@TODO

#### Packages inside Amplify JS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should explain what the packages are for. Since there a pattern of _interface vs. not, perhaps the best way to do this is with a leading paragraph:

_interface packages (do what), while the others provide an implementation. Currently, Amplify Flutter supports Authentication and Analytics. Both functionalities require the core module (for purpose).

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
mlabieniec and others added 7 commits August 16, 2020 09:59
Co-authored-by: Jameson Williams <jhwill@amazon.com>
Co-authored-by: Jameson Williams <jhwill@amazon.com>
Co-authored-by: Jameson Williams <jhwill@amazon.com>
Co-authored-by: Jameson Williams <jhwill@amazon.com>
Co-authored-by: Jameson Williams <jhwill@amazon.com>
Co-authored-by: Jameson Williams <jhwill@amazon.com>
Co-authored-by: Jameson Williams <jhwill@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants