Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): hot restart #3497

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix(datastore): hot restart #3497

merged 1 commit into from
Aug 3, 2023

Conversation

fjnoyp
Copy link
Contributor

@fjnoyp fjnoyp commented Aug 1, 2023

Issue #, if available:

#3368

Description of changes:

Ignore platform exceptions so that authenticator no longer freezes app with datastore on hot restart.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fjnoyp fjnoyp requested a review from a team as a code owner August 1, 2023 23:40
@fjnoyp fjnoyp self-assigned this Aug 1, 2023
@fjnoyp fjnoyp requested a review from Jordan-Nelson August 1, 2023 23:41
@fjnoyp fjnoyp force-pushed the fix/datastoreHotReload branch from 76a11ef to ad4f91c Compare August 1, 2023 23:43
Ignore platform exceptions so that authenticator no longer freezes app with datastore on hot restart.
@fjnoyp fjnoyp force-pushed the fix/datastoreHotReload branch from ad4f91c to a043617 Compare August 3, 2023 01:03
@fjnoyp fjnoyp requested a review from dnys1 August 3, 2023 01:04
@Jordan-Nelson Jordan-Nelson merged commit aafc570 into main Aug 3, 2023
NikaHsn pushed a commit that referenced this pull request Aug 7, 2023
Ignore platform exceptions so that authenticator no longer freezes app with datastore on hot restart.

Co-authored-by: kyle <kylechen@amazon.com>
ragingsquirrel3 pushed a commit that referenced this pull request Aug 7, 2023
Ignore platform exceptions so that authenticator no longer freezes app with datastore on hot restart.

Co-authored-by: kyle <kylechen@amazon.com>
ragingsquirrel3 pushed a commit that referenced this pull request Aug 7, 2023
- fix(auth): Android Hosted UI flakiness
- fix(auth): Remove `nonce` usage ([#3321](#3321))
- fix(datastore): hot restart ([#3497](#3497))
- fix(datastore): make event history list thread safe ([#3509](#3509))
- fix(push): Incorrect handling of simple alert ([#3502](#3502))
- perf(auth): Fetch auth session ([#3510](#3510))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Aug 8, 2023
- fix(auth): Android Hosted UI flakiness
- fix(auth): Remove `nonce` usage ([#3321](#3321))
- fix(datastore): hot restart ([#3497](#3497))
- fix(datastore): make event history list thread safe ([#3509](#3509))
- fix(push): Incorrect handling of simple alert ([#3502](#3502))
- perf(auth): Fetch auth session ([#3510](#3510))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Aug 8, 2023
- fix(auth): Android Hosted UI flakiness
- fix(auth): Remove `nonce` usage ([#3321](#3321))
- fix(datastore): hot restart ([#3497](#3497))
- fix(datastore): make event history list thread safe ([#3509](#3509))
- fix(push): Incorrect handling of simple alert ([#3502](#3502))
- perf(auth): Fetch auth session ([#3510](#3510))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@Jordan-Nelson Jordan-Nelson deleted the fix/datastoreHotReload branch October 20, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants