chore: added E2E Testing Stack Environment for logging #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
reviewed
Aug 2, 2023
infra/lib/logging/resources/config/remoteloggingconstraints.json
Outdated
Show resolved
Hide resolved
NikaHsn
force-pushed
the
feat/logging/cloudwatch
branch
from
4def22d to
8a67c5b
Compare
dnys1
reviewed
Aug 3, 2023
|
Can you rebase on the base branch so it shows only your changes? |
dnys1
reviewed
Aug 8, 2023
NikaHsn
approved these changes
Aug 9, 2023
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
khatruong2009
force-pushed
the
feat/logging/e2einfra
branch
from
50b89d6 to
36c8ab7
Compare
khatruong2009
added a commit
to khatruong2009/amplify-flutter
that referenced
this pull request
Aug 18, 2023
) * chore: added e2e test environment for non remote config * chore: add remote config integration test stack environment for logging * chore: correctly format imports using snake case. removed empty this.config object * chore: add license header to top of the file * chore: remove commented code * chore: remove commented code * remove unnecessary import Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: removed unnecessary path.join and fixed formatting * chore: removed unnecessary argument and fixed filepath * chore: added remoteconfig.js, fixed remoteloggingconstraints.json confusion * chore: remove unnecessary path.join * chore: added e2e test environment for non remote config * chore: add remote config integration test stack environment for logging * remove unnecessary import Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: added remoteconfig.js, fixed remoteloggingconstraints.json confusion * chore: added BUCKET to argument for handling remote config * chore: changed remoteconfig to typescript but still need types * chore: updated types for remote config * chore: changed argument to adjust to using NodejsFunction instead of Function * chore: updated typing for setCachedConfig * chore: removed old remoteconfig.js file and removed unnecessary import * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> --------- Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
khatruong2009
added a commit
that referenced
this pull request
Nov 27, 2023
* chore: added e2e test environment for non remote config * chore: add remote config integration test stack environment for logging * chore: correctly format imports using snake case. removed empty this.config object * chore: add license header to top of the file * chore: remove commented code * chore: remove commented code * remove unnecessary import Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: removed unnecessary path.join and fixed formatting * chore: removed unnecessary argument and fixed filepath * chore: added remoteconfig.js, fixed remoteloggingconstraints.json confusion * chore: remove unnecessary path.join * chore: added e2e test environment for non remote config * chore: add remote config integration test stack environment for logging * remove unnecessary import Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * chore: added remoteconfig.js, fixed remoteloggingconstraints.json confusion * chore: added BUCKET to argument for handling remote config * chore: changed remoteconfig to typescript but still need types * chore: updated types for remote config * chore: changed argument to adjust to using NodejsFunction instead of Function * chore: updated typing for setCachedConfig * chore: removed old remoteconfig.js file and removed unnecessary import * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> * Update infra/lib/logging/resources/lambda/remoteconfig.ts Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> --------- Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.