Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): fix logging infra stack #3788

Merged

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Sep 22, 2023

Issue #, if available:

Description of changes:

  • fix duplicate imports: AuthIntegrationTestStackEnvironmentProps, StorageIntegrationTestStack
  • set s3bucket autoDeleteObject to true so the logging stack can be destroyed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner September 22, 2023 21:24
@NikaHsn NikaHsn merged commit bf2e77e into aws-amplify:feat/logging/cloudwatch Sep 22, 2023
1 check passed
@NikaHsn NikaHsn deleted the fix/logging/infra branch September 22, 2023 21:38
khatruong2009 pushed a commit that referenced this pull request Nov 27, 2023
fix(logging): fix logging infra stack duplicate imports and set s3bucket autoDeleteObject to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants