feat: implement _isLoggable method #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikaHsn
reviewed
Oct 4, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
khatruong2009
force-pushed
the
feat-logging-isLoggable
branch
from
c01df68 to
0cc7564
Compare
NikaHsn
reviewed
Oct 4, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
…udwatch_logger_plugin.dart Co-authored-by: NikaHsn <nika.hasani@gmail.com>
NikaHsn
reviewed
Oct 4, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
NikaHsn
reviewed
Oct 4, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Show resolved
Hide resolved
NikaHsn
requested changes
Oct 5, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
…udwatch_logger_plugin.dart Co-authored-by: NikaHsn <nika.hasani@gmail.com>
Equartey
reviewed
Oct 6, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Outdated
Show resolved
Hide resolved
NikaHsn
approved these changes
Oct 9, 2023
fjnoyp
reviewed
Oct 9, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Show resolved
Hide resolved
fjnoyp
reviewed
Oct 9, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
Show resolved
Hide resolved
fjnoyp
reviewed
Oct 9, 2023
packages/logging_cloudwatch/aws_logging_cloudwatch/test/cloudwatch_logger_plugin_test.dart
Show resolved
Hide resolved
fjnoyp
approved these changes
Oct 9, 2023
khatruong2009
merged commit 1f07bfb
into
feat/logging/cloudwatch
146 of 159 checks passed
khatruong2009
added a commit
that referenced
this pull request
Nov 27, 2023
* feat: implement _isLoggable and corrected categoryLogLevel in UserLogLevel class * chore: added _userId private variable instead of using method variable * chore: add aft workflows * chore: added helper method make sure category keys match * chore: removed unnecessary new listener * Update packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart Co-authored-by: NikaHsn <nika.hasani@gmail.com> * chore: removed white spaces * chore: added tests, tests methods, and fixed a typ * Update packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart Co-authored-by: NikaHsn <nika.hasani@gmail.com> * chore: removed testing methods and adjusted tests * chore: WIP - changed tests for handleLogEntry * chore: added future<void>.delay(0) to tests * chore: updated remote_constraint_provider_test * updated the tests * chore: flattened if statement --------- Co-authored-by: NikaHsn <nika.hasani@gmail.com> Co-authored-by: Nika Hassani <nikaws@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Implement _isLoggable method to filter logs based on category and user constraints.
Also corrected the category log level type in UserLogLevel class
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.