Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove exception during token timeout #3939

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

Jordan-Nelson
Copy link
Member

@Jordan-Nelson Jordan-Nelson commented Oct 11, 2023

Issue #, if available: #3737

Description of changes:

  • Replace PushNotificationException with logger.error when fetching device token times out.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson marked this pull request as ready for review October 11, 2023 18:02
@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner October 11, 2023 18:02
@Jordan-Nelson Jordan-Nelson changed the title chore: remove exception during token timeout fix: remove exception during token timeout Oct 11, 2023
'Timed out awaiting for device token.'
' This may happen when the native app has not been correctly configured'
' for push notifications. Review push notification configurations'
' of the native iOS and Android apps of your Flutter project.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do we have docs link we can provide here?

@Jordan-Nelson Jordan-Nelson merged commit 07fcfe1 into main Oct 20, 2023
@Jordan-Nelson Jordan-Nelson deleted the chore/notifications/token-timeout branch October 20, 2023 18:26
Equartey pushed a commit that referenced this pull request Oct 26, 2023
* chore: remove exception during token timeout

* fix: only call _registerDevice if device token exists

* chore: update device token timeout test
Equartey added a commit that referenced this pull request Oct 26, 2023
### Features
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

### Fixes
- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

### Breaking Changes
- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Oct 26, 2023
### Features
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

### Fixes
- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

### Breaking Changes
- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey pushed a commit that referenced this pull request Oct 30, 2023
* chore: remove exception during token timeout

* fix: only call _registerDevice if device token exists

* chore: update device token timeout test
Equartey added a commit that referenced this pull request Oct 30, 2023
### Features
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

### Fixes
- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

### Breaking Changes
- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Oct 30, 2023
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Nov 6, 2023
* chore(version): Bump version

- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee

* fix: slide smithy_codegen window

* fix: added drop dep
khatruong2009 pushed a commit that referenced this pull request Nov 7, 2023
* chore: remove exception during token timeout

* fix: only call _registerDevice if device token exists

* chore: update device token timeout test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants