chore(logging): fixes and improvement to logging example app #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjnoyp
changed the title
fjnoyp
force-pushed
the
feat/logging/cloudwatch-fix-example-app
branch
from
9a9c89b to
51efa5a
Compare
NikaHsn
reviewed
Oct 12, 2023
.../logging_cloudwatch/amplify_logging_cloudwatch/example/lib/amplifyconfiguration_logging.dart
Outdated
Show resolved
Hide resolved
| this.category, | ||
| this.logger, | ||
| this.logMsgController, { | ||
| this.logLevel = LogLevel.verbose, |
There was a problem hiding this comment.
nit: better to not set a default value so the log level would be null if not set by user.
There was a problem hiding this comment.
Is that desired behavior though? Since if it's null the logic prevents any log from being sent while wiping the user's log message that they wrote?
There was a problem hiding this comment.
good observation. the way I see it is if the log level is not set then user would see it and set the value. given the app does not show error if user does not set the log level but put a log message and wipes out the log message it is a good idea to set the log level to vebose.
This reverts commit f56337e.
NikaHsn
approved these changes
Oct 12, 2023
haverchuck
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix and clean logger example app.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.