Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved user agent to logging category api #4118

Merged
merged 3 commits into from
Nov 14, 2023
Merged

chore: moved user agent to logging category api #4118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94e7452
chore: moved user agent to logging category api
khatruong2009 Nov 13, 2023
0a51dfe
chore: added trailing comma for formatting
khatruong2009 Nov 14, 2023
12a4e51
chore: ran dart format
khatruong2009 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/amplify_core/lib/src/category/amplify_logging_category.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ class LoggingCategory extends AmplifyCategory<LoggingPluginInterface> {
/// Sends recorded logs to the output and remove them from the local storage.
/// {@endtemplate}
void flushLogs() {
return defaultPlugin.flushLogs();
return identifyCall(
LoggingCategoryMethod.flush,
() => defaultPlugin.flushLogs(),
);
}
}
5 changes: 1 addition & 4 deletions packages/logging_cloudwatch/aws_logging_cloudwatch/lib/src/cloudwatch_logger_plugin.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,7 @@ class CloudWatchLoggerPlugin extends AWSLoggerPlugin

/// Sends logs on-demand to CloudWatch.
Future<void> flushLogs() async {
await identifyCall(
LoggingCategoryMethod.flush,
_startSyncingIfNotInProgress,
);
await _startSyncingIfNotInProgress();
}

@override
Expand Down
Loading