feat(smithy)!: remove error match on http status code #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
force-pushed
the
chore/smithy/remove-status-code-match
branch
2 times, most recently
from
eaa31c9 to
8c1a9e6
Compare
Jordan-Nelson
changed the title
Jordan-Nelson
force-pushed
the
chore/smithy/remove-status-code-match
branch
from
8c1a9e6 to
83f488b
Compare
Jordan-Nelson
changed the title
Jordan-Nelson
changed the title
Equartey
approved these changes
Apr 24, 2024
NikaHsn
approved these changes
Apr 24, 2024
Equartey
pushed a commit
that referenced
this pull request
Apr 25, 2024
* fix!: remove http status code exception mapping * chore: update remaining test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Prior to this change smithy contains logic to attempt to determine what type of exception should be thrown based on first the error name/shape (Ex: Access Denied) and then the http status code (ex: 403). The issue with this is that some services (S3) have operations that can return multiple errors for a single status code. For example, a 403 http status code during a GetObject operation can mean AccessDenied OR InvalidObjectState. By mapping based on the http status alone the first exception gets thrown.
With the changes smithy will throw a generic SmithyHttpException when it cannot match the error type based on the name/shape. This allows the consumer (Amplify) to handle the exception as appropriate.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.