Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace mockito with mocktail #4813

Merged
merged 1 commit into from
May 4, 2024

Conversation

Jordan-Nelson
Copy link
Member

@Jordan-Nelson Jordan-Nelson commented May 3, 2024

Description of changes:

  • replace mockito with mocktail in amplify_push_notifications_pinpoint

mockito requires code generation and the current generated mocks are out of date which is leading to issue with publishing packages. Rather than update the mocks, this PR replaces mockito with mocktail which does not use code generation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson marked this pull request as ready for review May 3, 2024 22:28
@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner May 3, 2024 22:28
@Jordan-Nelson Jordan-Nelson merged commit dc7de26 into main May 4, 2024
6 checks passed
@Jordan-Nelson Jordan-Nelson deleted the chore/push_notifications_pinpoint_mocktail branch May 4, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants