fix(api): GraphQLResponse.toString() include data & errors #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
approved these changes
Jun 26, 2024
NikaHsn
approved these changes
Jun 26, 2024
hahnandrew
pushed a commit
that referenced
this pull request
Jun 27, 2024
Jordan-Nelson
pushed a commit
that referenced
this pull request
Jun 27, 2024
Jordan-Nelson
added a commit
that referenced
this pull request
Jun 27, 2024
### Fixes - fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079)) - fix(core): improve amplify configure api error message ([#5021](#5021)) - fix(notifications): allow offline configuration - fix: wait for in progress multi part uploads to cancel for `pause` and `cancel` ### Features - feat: Support Amplify Gen 2 outputs ([#5073](#5073)) Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson
added a commit
that referenced
this pull request
Jun 27, 2024
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079)) - fix(core): improve amplify configure api error message ([#5021](#5021)) - fix(notifications): allow offline configuration - fix: wait for in progress multi part uploads to cancel for `pause` and `cancel` - feat: Support Amplify Gen 2 outputs ([#5073](#5073)) Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson
added a commit
that referenced
this pull request
Jun 27, 2024
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079)) - fix(core): improve amplify configure api error message ([#5021](#5021)) - fix(notifications): allow offline configuration - fix: wait for in progress multi part uploads to cancel for `pause` and `cancel` - feat: Support Amplify Gen 2 outputs ([#5073](#5073)) Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson
pushed a commit
that referenced
this pull request
Jun 27, 2024
Jordan-Nelson
added a commit
that referenced
this pull request
Jun 27, 2024
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079)) - fix(core): improve amplify configure api error message ([#5021](#5021)) - fix(notifications): allow offline configuration - fix: wait for in progress multi part uploads to cancel for `pause` and `cancel` - feat: Support Amplify Gen 2 outputs ([#5073](#5073)) Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson
added a commit
that referenced
this pull request
Jun 27, 2024
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079)) - fix(core): improve amplify configure api error message ([#5021](#5021)) - fix(notifications): allow offline configuration - fix: wait for in progress multi part uploads to cancel for `pause` and `cancel` - feat: Support Amplify Gen 2 outputs ([#5073](#5073)) Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Jordan-Nelson
added a commit
that referenced
this pull request
Jun 27, 2024
- fix(api): GraphQLResponse.toString() include data & errors ([#5079](#5079)) - fix(core): improve amplify configure api error message ([#5021](#5021)) - fix(notifications): allow offline configuration - fix: wait for in progress multi part uploads to cancel for `pause` and `cancel` - feat: Support Amplify Gen 2 outputs ([#5073](#5073)) Updated-Components: libgit2dart, amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This changes the output of
GraphQLResponse.toString()to include bothdataanderrorproperties regardless of the presence of errors. Since a valid GraphQL response could contain a both, users previously would be missing context when errors were present.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.