Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): allow configuration when auth token is expired #5117

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Jul 5, 2024

Issue #, if available: #5109

Description of changes:

  • this is to allow Amplify Push Notifications to configure successfully when refresh token is expired.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner July 5, 2024 18:42
// throws UnknownException due to expired token.
// the underlying exception is `NotAuthorizedException` with
// `Invalid login token. Token expired` message.
} on UnknownException catch (e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q(non-blocking): can this be scoped to NotAuthorizedException?

@khatruong2009 khatruong2009 merged commit 15aa405 into main Jul 9, 2024
6 checks passed
Equartey pushed a commit that referenced this pull request Jul 17, 2024
Equartey added a commit that referenced this pull request Jul 17, 2024
### Fixes
- fix(datastore): prevent auth plugin from throwing during configuration ([#5132](#5132))
- fix(notifications): allow configuration when auth token is expired ([#5117](#5117))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@Equartey Equartey mentioned this pull request Jul 17, 2024
Equartey pushed a commit that referenced this pull request Jul 17, 2024
Equartey added a commit that referenced this pull request Jul 17, 2024
### Fixes
- fix(datastore): prevent auth plugin from throwing during configuration ([#5132](#5132))
- fix(notifications): allow configuration when auth token is expired ([#5117](#5117))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey pushed a commit that referenced this pull request Jul 17, 2024
Equartey added a commit that referenced this pull request Jul 17, 2024
### Fixes
- fix(datastore): prevent auth plugin from throwing during configuration ([#5132](#5132))
- fix(notifications): allow configuration when auth token is expired ([#5117](#5117))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Jul 17, 2024
### Fixes
- fix(datastore): prevent auth plugin from throwing during configuration ([#5132](#5132))
- fix(notifications): allow configuration when auth token is expired ([#5117](#5117))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@NikaHsn NikaHsn deleted the fix/push-notification branch August 7, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants