Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): app life cycle 'resume' triggers web socket reconnection #5567

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

tyllark
Copy link
Member

@tyllark tyllark commented Oct 17, 2024

Issue #, if available:
#5041

Description of changes:
Added an app life cycle stream/listener to reconnect API web sockets after the app is paused and resumed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tyllark tyllark requested a review from a team as a code owner October 17, 2024 15:09
Copy link
Contributor

@Equartey Equartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and its working great. Left two small nits, otherwise looks good! Nice work

@tyllark tyllark changed the title Fix/app life cycle datastore websockets fix(api): app life cycle datastore websockets Oct 17, 2024
ekjotmultani
ekjotmultani previously approved these changes Oct 17, 2024
@Equartey Equartey changed the title fix(api): app life cycle datastore websockets fix(api): app life cycle 'resume' triggers web socket reconnection Oct 18, 2024
@tyllark tyllark merged commit 8222a03 into main Oct 18, 2024
57 checks passed
Equartey pushed a commit that referenced this pull request Oct 21, 2024
…5567)

* fix(api): Reconnect WebSocket when resuming app from a paused state
Equartey added a commit that referenced this pull request Oct 21, 2024
Version successfully bumped
chore(version): Bump version

### Features
- feat(api): move App Sync subscription headers to protocol ([#5301](#5301))
- feat(authenticator): export unmet password requirements ([#5437](#5437))

### Fixes
- fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Oct 21, 2024
### Features
- feat(api): move App Sync subscription headers to protocol ([#5301](#5301))
- feat(authenticator): export unmet password requirements ([#5437](#5437))

### Fixes
- fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey pushed a commit that referenced this pull request Oct 21, 2024
…5567)

* fix(api): Reconnect WebSocket when resuming app from a paused state
Equartey added a commit that referenced this pull request Oct 21, 2024
### Features
- feat(api): move App Sync subscription headers to protocol ([#5301](#5301))
- feat(authenticator): export unmet password requirements ([#5437](#5437))

### Fixes
- fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey pushed a commit that referenced this pull request Oct 22, 2024
…5567)

* fix(api): Reconnect WebSocket when resuming app from a paused state
Equartey added a commit that referenced this pull request Oct 22, 2024
### Features
- feat(api): move App Sync subscription headers to protocol ([#5301](#5301))
- feat(authenticator): export unmet password requirements ([#5437](#5437))

### Fixes
- fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Oct 22, 2024
### Features
- feat(api): move App Sync subscription headers to protocol ([#5301](#5301))
- feat(authenticator): export unmet password requirements ([#5437](#5437))

### Fixes
- fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Oct 23, 2024
chore(version): Bump version

### Features
- feat(api): move App Sync subscription headers to protocol ([#5301](#5301))
- feat(authenticator): export unmet password requirements ([#5437](#5437))

### Fixes
- fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
ekjotmultani pushed a commit that referenced this pull request Nov 4, 2024
…5567)

* fix(api): Reconnect WebSocket when resuming app from a paused state
ekjotmultani pushed a commit that referenced this pull request Nov 4, 2024
chore(version): Bump version

### Features
- feat(api): move App Sync subscription headers to protocol ([#5301](#5301))
- feat(authenticator): export unmet password requirements ([#5437](#5437))

### Fixes
- fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants