fix(datastore): properly handle multiple configures on Android #5740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5244
#5458
Description of changes:
Calling configure multiple times on Datastore results in exceptions and other unexpected behavior:
AmplifyAlreadyConfiguredException
rather thanUser-Agent was already configured successfully
so it can be handle upstream.onDetachedFromEngine
otherwise events would be duplicated from the listeners that were not cleaned up.nativeAuthPlugin
a companion object since we cannot add a new plugin after calling configure, but we need to handle the case whereonDetachedFromEngine
sets this value to null and it is reassigned viaonAttachedToEngine
from a new instance ofAmplifyDataStorePlugin
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.