Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dx): Drop min. Xcode version from 13.0 to 12.0 #14

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

atierian
Copy link
Member

Issue #, if available:
N/A

Description of changes:
No functional changes. This PR drops the internal usage of Swift >5.3 language features in order to support Xcode 12.

Check points: (check or cross out if not relevant)

  • Ran swiftformat (from repository root): swiftformat Sources Tests
  • Ran swiftlint (from repository root): swiftlint Sources Tests and addressed all violations.
  • Added new tests to cover change, if needed
  • Build succeeds with all targets using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Documentation update for the change if required (Amplify docs change will be made after merge)
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ameter ameter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atierian atierian merged commit f3dd65f into main Nov 24, 2021
@atierian atierian deleted the feat/xcode-12-support branch November 24, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants