Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing compilation issues with new Amplify version. #34

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ruisebas
Copy link
Member

Description of changes:

This PR fixes the compilations issues coming from Amplify now using version 1.0.0 of the Swift SDK, since some types and parameters have have been renamed/relocated.

Check points: (check or cross out if not relevant)

  • Ran swiftformat (from repository root): swiftformat Sources Tests
  • Ran swiftlint (from repository root): swiftlint Sources Tests and addressed all violations.
  • Added new tests to cover change, if needed
  • Build succeeds with all targets using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested a review from a team as a code owner September 18, 2024 18:35
@ruisebas ruisebas merged commit 311b0e7 into main Sep 18, 2024
2 checks passed
@ruisebas ruisebas deleted the ruisebas/upgrade-amplify branch September 18, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants