feat(storage): address feedbacks

packages/storage/__tests__/storageBrowser/managedAuthAdapter/createManagedAuthConfigAdapter.test.ts

@@ -0,0 +1,72 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+import { createManagedAuthConfigAdapter } from '../../../src/storageBrowser/managedAuthConfigAdapter';
+import { createListLocationsHandler } from '../../../src/storageBrowser/managedAuthConfigAdapter/createListLocationsHandler';
+import { createLocationCredentialsHandler } from '../../../src/storageBrowser/managedAuthConfigAdapter/createLocationCredentialsHandler';
+
+jest.mock(
+	'../../../src/storageBrowser/managedAuthConfigAdapter/createListLocationsHandler',
+);
+jest.mock(
+	'../../../src/storageBrowser/managedAuthConfigAdapter/createLocationCredentialsHandler',
+);
+
+describe('createManagedAuthConfigAdapter', () => {
+	const region = 'us-foo-2';
+	const accountId = 'XXXXXXXXXXXX';
+	const credentialsProvider = jest.fn();
+
+	beforeEach(() => {
+		jest
+			.mocked(createListLocationsHandler)
+			.mockReturnValue('LIST_LOCATIONS_FN' as any);
+		jest
+			.mocked(createLocationCredentialsHandler)
+			.mockReturnValue('GET_LOCATION_CREDENTIALS_FN' as any);
+	});
+
+	afterEach(() => {
+		jest.clearAllMocks();
+	});
+
+	it('should pass region to the adapter', () => {
+		expect(createManagedAuthConfigAdapter({ region } as any)).toMatchObject({
+			region,
+		});
+	});
+
+	it('should create list locations handler', () => {
+		expect(
+			createManagedAuthConfigAdapter({
+				region,
+				accountId,
+				credentialsProvider,
+			}),
+		).toMatchObject({
+			listLocations: 'LIST_LOCATIONS_FN',
+		});
+		expect(createListLocationsHandler).toHaveBeenCalledWith({
+			region,
+			accountId,
+			credentialsProvider,
+		});
+	});
+
+	it('should create get location credentials handler', () => {
+		expect(
+			createManagedAuthConfigAdapter({
+				region,
+				accountId,
+				credentialsProvider,
+			}),
+		).toMatchObject({
+			getLocationCredentials: 'GET_LOCATION_CREDENTIALS_FN',
+		});
+		expect(createLocationCredentialsHandler).toHaveBeenCalledWith({
+			region,
+			accountId,
+			credentialsProvider,
+		});
+	});
+});

packages/storage/src/storageBrowser/index.ts

@@ -2,9 +2,5 @@
 // SPDX-License-Identifier: Apache-2.0
 
 export { createLocationCredentialsStore } from './locationCredentialsStore';
-export { createManagedAuthAdapter } from './managedAuthAdapter/createManagedAuthAdapter';
-export {
-	GetLocationCredentials,
-	ListLocations,
-	StorageBrowserConfigAdapter,
-} from './types';
+export { createManagedAuthConfigAdapter } from './managedAuthConfigAdapter/createManagedAuthConfigAdapter';
+export { GetLocationCredentials, ListLocations } from './types';

packages/storage/src/storageBrowser/managedAuthConfigAdapter/createManagedAuthConfigAdapter.ts

@@ -0,0 +1,52 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+import {
+	CredentialsProvider,
+	GetLocationCredentials,
+	ListLocations,
+} from '../types';
+
+import { createListLocationsHandler } from './createListLocationsHandler';
+import { createLocationCredentialsHandler } from './createLocationCredentialsHandler';
+
+interface CreateManagedAuthConfigAdapterInput {
+	accountId: string;
+	region: string;
+	credentialsProvider: CredentialsProvider;
+}
+
+interface StorageBrowserAuthConfigAdapter {
+	listLocations: ListLocations;
+	getLocationCredentials: GetLocationCredentials;
+	region: string;
+}
+
+/**
+ * Create configuration including handlers for StorageBrowser to call S3 Access Grants
+ * APIs to list and get credentials for different locations.
+ *
+ * @param options - Configuration options for the adapter.
+ * @returns - An object containing the handlers for StorageBrowser to call S3 Access Grants APIs and region
+ */
+export const createManagedAuthConfigAdapter = ({
+	credentialsProvider,
+	region,
+	accountId,
+}: CreateManagedAuthConfigAdapterInput): StorageBrowserAuthConfigAdapter => {
+	const listLocations = createListLocationsHandler({
+		credentialsProvider,
+		accountId,
+		region,
+	});
+	const getLocationCredentials = createLocationCredentialsHandler({
+		credentialsProvider,
+		accountId,
+		region,
+	});
+
+	return {
+		listLocations,
+		getLocationCredentials,
+		region,
+	};
+};

packages/storage/src/storageBrowser/managedAuthConfigAdapter/index.ts

@@ -0,0 +1,4 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+export { createManagedAuthConfigAdapter } from './createManagedAuthConfigAdapter';

packages/storage/src/storageBrowser/types.ts

@@ -98,14 +98,3 @@ export interface LocationCredentialsStore {
 	 */
 	destroy(): void;
 }
-
-/**
- * Common interface for handlers to configure StorageBrowser behaviors
- *
- * @internal
- */
-export interface StorageBrowserConfigAdapter {
-	listLocations: ListLocations;
-	getLocationCredentials: GetLocationCredentials;
-	region: string;
-}