Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 arrow function syntax breaking Internet Explorer 11 (IE11) #5582

Closed
sawyerh opened this issue Apr 27, 2020 · 14 comments
Closed

ES6 arrow function syntax breaking Internet Explorer 11 (IE11) #5582

sawyerh opened this issue Apr 27, 2020 · 14 comments
Assignees
Labels
aws-sdk-js bug Something isn't working

Comments

@sawyerh
Copy link

sawyerh commented Apr 27, 2020

Describe the bug

Amplify does not work in Internet Explorer 11. It's possible this was broken by a dependency like @aws-sdk. It's unclear how to restore IE11 support to an application implementing Amplify.

To Reproduce

Repro available here: https://github.com/sawyerh/amplify-nextjs-ssr

Expected behavior
It's unclear what the official browser support is for Amplify, however the Amplify SDK previously worked in IE 11, and according to this comment AWS is still supporting IE11.

Screenshots
image

What is Configured?

"dependencies": {
    "aws-amplify": "3.0.9",
    "aws-amplify-react": "4.1.8",
    "next": "9.3.5",
    "react": "16.13.1",
    "react-dom": "16.13.1"
  }
@sawyerh sawyerh added the to-be-reproduced Used in order for Amplify to reproduce said issue label Apr 27, 2020
@Amplifiyer
Copy link
Contributor

Same as #5405
The issue is with an upgrade of underlying aws-sdk that is exporting the package with ES2016 syntax https://github.com/aws/aws-sdk-js-v3/blob/v1.0.0-beta.5/packages/middleware-serde/tsconfig.json#L3 and there is an open issue related to this aws/aws-sdk-js-v3#1099

@petrachemarin
Copy link

I have the same issue, is there an older version that didn't had this problem?

@ericclemmons
Copy link
Contributor

Awaiting a version bump for https://www.npmjs.com/package/@aws-sdk/eventstream-serde-browser

@slavco86
Copy link

Having same issue.
@ericclemmons
How long till the version bump?

@jonasduever
Copy link

Still an issue, I think. :/

  "dependencies": {
    ...
    "aws-amplify": "~3.0.12",
    "aws-amplify-angular": "~5.0.12",
    ...
  }

image

@Amplifiyer
Copy link
Contributor

it seems there is one more package that got missed which targets ES2016 output https://github.com/aws/aws-sdk-js-v3/blob/v1.0.0-gamma.2/packages/middleware-serde/tsconfig.json#L3
I'll create an issue with aws-sdk to get this prioritized.

@jonasduever
Copy link

aws/aws-sdk-js-v3#1245 has been merged - looks like this problem will be solved soon 👍

@simmbiote
Copy link

I bumped aws-amplify version up to 3.0.18, but still getting the same error.

image

I've also tried a variety of polyfills:

import "babel-polyfill"; 
import "promise-polyfill";
import "core-js/es/typed-array/uint32-array";
import "core-js/es/array/find";
import "core-js/es/object/assign";
import "core-js/es/object/entries";

Still not working. Any help would be appreciated!

@KwFung7
Copy link

KwFung7 commented Jul 9, 2020

aws/aws-sdk-js-v3#1319
The issue should be fixed in latest aws sdk v1.0.0-gamma.3 release (https://github.com/aws/aws-sdk-js-v3/releases/tag/v1.0.0-gamma.3

@simmbiote
Copy link

I ended up removing this package and using a different solution for logging in AWS Cognito users

@wataruoguchi
Copy link

"Amazon Cognito Auth" ^ is already archived. The module doesn't support PKCE, so I'd stick with amplify-js.

As it's mentioned, the latest aws sdk v1.0.0-gamma.3 release has the bugfix. It is now tagged to gamma. I resolved this issue by installing @aws-sdk/middleware-serde@gamma.

@sammartinez
Copy link
Contributor

Resolving as this issue is in our latest release, 3.0.22

@wataruoguchi
Copy link

Awesome! Thank you!

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-js bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants