-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aws-sdk to gamma version #5854
Conversation
This pull request introduces 1 alert when merging 48bf251 into e71fee5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 986b74b into f89e545 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 8a27e12 into 24eb104 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #5854 +/- ##
==========================================
- Coverage 73.75% 73.75% -0.01%
==========================================
Files 204 203 -1
Lines 11973 11970 -3
Branches 2254 2254
==========================================
- Hits 8831 8828 -3
Misses 2980 2980
Partials 162 162
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 73dfe26 into 3b2ec1b - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @Amplifiyer !!
My only comment as we talked before, is to change the return type of Storage.get
when download: true
that might need to be overloaded probably to set the correct type when download: false
(url)
s3BucketEndpoint: true, | ||
s3ForcePathStyle: true, | ||
tls: false, | ||
bucketEndpoint: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was bucketEndpoint changed to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a change in the aws-sdk interpretation of bucketEndpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we call this out in the readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a 100% non-breaking change for Amplify customers
Thanks @elorzafe. The type that's changing is the result.Body. Is there any trick shortcut to specify a type definition that explicitly has one member of a specific type but otherwise generic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just for reference: This update to gamma cause this critical issue, as all S3 uploads stopped working in Chrome: |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
PUT
request is sent to thehttps
endpoint instead of thehttp
#5320Description of changes:
Note: The build won't succeed until aws-sdk release their gamma version. I've been testing with a local copy of cached verdaccio release.
This PR is to upgrade aws-sdk version which fixes the above mentioned amplify issues. There are some compatibility changes since this release of aws-sdk is not 100% backwards compatible.
tls
to enforce http endpoints.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.