Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth debouncing hotfix #10082

Merged

Conversation

jamesaucode
Copy link
Contributor

Description of changes

Change userSession debouncing logic

Issue #, if available

N/A

Description of how you validated changes

yarn build && yarn test
Manual test on sample app

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Thanks @jamesaucode

dpilch and others added 11 commits July 13, 2022 17:46
Imports specific functions instead of the whole JS module to improve bundle size
Co-authored-by: Chris Fang <chrfang@amazon.com>
aws-amplify#10047)

* fix(amazon-cognito-identity-js): Missing cognito user challenge name type

* fix(type): Fix other functions reported in aws-amplify#6974

* Update Auth units with correct ChallengeName

Co-authored-by: elorzafe <elorzafe@amazon.com>
 - amazon-cognito-identity-js@5.2.10
 - @aws-amplify/ui-angular@1.0.54
 - @aws-amplify/ui-components@1.9.25
 - @aws-amplify/ui-react@1.2.45
 - @aws-amplify/ui-storybook@2.0.45
 - @aws-amplify/ui-vue@1.1.39
 - @aws-amplify/analytics@5.2.12
 - @aws-amplify/api-graphql@2.3.9
 - @aws-amplify/api-rest@2.0.45
 - @aws-amplify/api@4.0.45
 - @aws-amplify/auth@4.5.9
 - aws-amplify-angular@6.0.45
 - aws-amplify-react@5.1.28
 - aws-amplify-vue@2.1.7
 - aws-amplify@4.3.27
 - @aws-amplify/cache@4.0.47
 - @aws-amplify/core@4.5.9
 - @aws-amplify/datastore-storage-adapter@1.3.5
 - @aws-amplify/datastore@3.12.2
 - @aws-amplify/geo@1.3.8
 - @aws-amplify/interactions@4.0.45
 - @aws-amplify/predictions@4.0.45
 - @aws-amplify/pubsub@4.4.6
 - @aws-amplify/pushnotification@4.3.24
 - @aws-amplify/storage@4.4.28
 - @aws-amplify/xr@3.0.45
@codecov-commenter
Copy link

Codecov Report

Merging #10082 (1987f9b) into fix/auth-debouncing (8ad7d6a) will increase coverage by 0.51%.
The diff coverage is 84.61%.

@@                   Coverage Diff                   @@
##           fix/auth-debouncing   #10082      +/-   ##
=======================================================
+ Coverage                83.62%   84.13%   +0.51%     
=======================================================
  Files                      253      253              
  Lines                    18277    18269       -8     
  Branches                  3921     3919       -2     
=======================================================
+ Hits                     15284    15371      +87     
+ Misses                    2901     2807      -94     
+ Partials                    92       91       -1     
Impacted Files Coverage Δ
...ages/datastore/src/sync/processors/subscription.ts 73.55% <25.00%> (+34.32%) ⬆️
packages/auth/src/Auth.ts 86.96% <88.88%> (+0.23%) ⬆️
packages/analytics/src/Providers/EventBuffer.ts 36.03% <100.00%> (+5.40%) ⬆️
packages/auth/src/urlListener.ts 87.50% <100.00%> (ø)
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)
packages/datastore/__tests__/helpers.ts 90.00% <100.00%> (+1.11%) ⬆️
...ackages/datastore/src/sync/processors/errorMaps.ts 100.00% <0.00%> (+27.65%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@elorzafe elorzafe merged commit 857b8f6 into aws-amplify:fix/auth-debouncing Jul 14, 2022
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server amplify-help forum.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants