chore: Added custom AnalyticsProvider test #11618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvramyasri7
reviewed
Jul 12, 2023
kvramyasri7
previously approved these changes
Jul 12, 2023
Contributor
kvramyasri7
left a comment
kvramyasri7
left a comment
There was a problem hiding this comment.
LGTM! Thanks @jimblanc
cshfang
previously approved these changes
Jul 12, 2023
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
israx
approved these changes
Jul 12, 2023
kvramyasri7
approved these changes
Jul 12, 2023
cshfang
approved these changes
Jul 12, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11618 +/- ##
==========================================
+ Coverage 83.67% 83.69% +0.01%
==========================================
Files 340 340
Lines 21549 21549
Branches 4604 4604
==========================================
+ Hits 18032 18036 +4
+ Misses 3230 3226 -4
Partials 287 287 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a basic unit test to exercise custom
AnalyticsProviderfunctionality.Issue #, if available
Description of how you validated changes
Local run.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.