Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 1165 #1254

Merged
merged 6 commits into from
Jul 20, 2018
Merged

Fix for 1165 #1254

merged 6 commits into from
Jul 20, 2018

Conversation

powerful23
Copy link
Contributor

@powerful23 powerful23 commented Jul 17, 2018

Issue #, if available:
fixes #1165
fixes #1204
fixes #1259
Adds an api to get current preferred mfa type.
Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -403,6 +403,7 @@ export default class AuthClass {

/**
* get user current preferred mfa option
* this method doesn't work with totp, we need to deprecate it.
* @param {CognitoUser} user - the current user
* @return - A promise resolves the current preferred mfa option if success

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deprecated

@MiroslavPetrik
Copy link

@powerful23 actually when the MFA is disabled, the getUserData response does not have key PreferredMfaSetting. Therefore it would be cool to add

const preferredMFA = data.PreferredMfaSetting || 'NOMFA';

in the getPreferredMFA method.

@powerful23
Copy link
Contributor Author

@MiroslavPetrik Thanks, will update it.

@MiroslavPetrik
Copy link

@powerful23 when do you plan to publish this?

@powerful23
Copy link
Contributor Author

@MiroslavPetrik I am going to do a publish this week.

@powerful23 powerful23 deleted the fix-for-1165 branch August 6, 2018 20:58
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants