chore(repo): migrate to eslint #12620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/chore/repo/migrate-eslint
branch
from
7d944fa to
2cf1ba2
Compare
|
Please ensure that this PR:
A repository administrator is required to review & merge this change. |
HuiSF
force-pushed
the
hui/chore/repo/migrate-eslint
branch
from
2cf1ba2 to
3510e6e
Compare
cshfang
reviewed
Nov 27, 2023
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.detectIndentation": false, | ||
| "editor.formatOnSave": true, | ||
| "editor.insertSpaces": false, |
There was a problem hiding this comment.
I'd like to use space in ALL places instead of tabs one day🙏
kvramyasri7
reviewed
Nov 29, 2023
HuiSF
force-pushed
the
hui/chore/repo/migrate-eslint
branch
from
3510e6e to
38f7430
Compare
cshfang
previously approved these changes
Nov 29, 2023
HuiSF
force-pushed
the
hui/chore/repo/migrate-eslint
branch
from
fcbba77 to
800b89a
Compare
cshfang
previously approved these changes
Nov 29, 2023
HuiSF
force-pushed
the
hui/chore/repo/migrate-eslint
branch
from
1c92785 to
cf1496d
Compare
squash to graphql-api
HuiSF
force-pushed
the
hui/chore/repo/migrate-eslint
branch
from
cf1496d to
54a4dd4
Compare
jimblanc
approved these changes
Dec 21, 2023
AllanZhengYP
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
typescript5.0.2 in the workspace!tsconfig.jsonsetup and its branching across packages../../../moduleimport pathseslint --fixfor each package to auto fix lint issues (approximately 80% of the changes), plus manual fixes (approximately 20% of the changes)NOTE: This PR upgrades typescript 5.0.2 which breaks the existing jest set up, this PR will depends on #12607 to work (hence marked as Draft PR, and currently
__tests__is ignored by eslint ).NOTE: Please DO NOT click on update branch button. Thanks
What's new after rebasing off origin/main
__tests__to let the unit tests run (in the commits that are with message: "squash to the previous"...)Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.