chore: Upgrade Prettier #13017
Merged
chore: Upgrade Prettier #13017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stocaaro
approved these changes
Feb 15, 2024
HuiSF
approved these changes
Feb 15, 2024
jimblanc
approved these changes
Feb 15, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Prettier 3.2 introduced a change which now aligns the whitespacing correctly for conditionals. This, in turn, was causing files containing this difference that haven't been formatted to flag as errors given our transition from TSLint to ESLint. At this time, not every package has yet been migrated and so, to avoid having this issue crop up as the migrations continue to take place, upgrading Prettier and running the library through the formatter to better set the stage for the ongoing migration.
This PR upgrades Prettier to the latest version (3.2.5) which includes the above changes and formats the repo via
$ yarn prettier --write .Description of how you validated changes
yarn testyarn lintChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.