-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for specifying a custom endpoint for identity pools: issue 11275 #13025
feat: Added support for specifying a custom endpoint for identity pools: issue 11275 #13025
Conversation
…dpoint-for-identityPools' of github.com:snagatsu/amplify-js into feat/Add-endpoint-for-identityPools
Hi @snagatsu thank you for your contribution! I'll review this with the team and follow up with any comments/updates. |
any updates on this PR? |
there is no additional information available |
Hi @snagatsu, thanks a lot for the contribution. It helps a lot when we triage the feature requests. As of the implementation, the proposed one does not quite conform to our abstractions. The main issue is that we need to resolve the Amplify configuration for endpoint in the provider layer like here and keep the amplify-js/packages/auth/src/providers/cognito/credentialsProvider/credentialsProvider.ts Line 27 in f049a9e
For changes that modifies that public interfaces like this one, we need to go through internal processes to make sure their naming is reasonable and consistent. We also need to update our documentation too. I will bring this to the team to discuss and keep you updated. The team might pick up the feature request. |
Hi @snagatsu After another review I think the change in current status makes sense. Currently we will be vetting the new configuration name with the team. |
any updates on this PR? |
@snagatsu, @adadouche, and @dmytzo Wanted to follow up on this. We've got this feature request captured within issue #13445 and the corresponding PR #13552. As such, we'll this PR out as a duplicate and recommend you follow those two for updates on progress. |
Description of changes
you can specify a custom endpoint for accessing a Cognito user pool, such as signIn or signOut. However, you cannot specify a custom endpoint for accessing an identity pool, such as fetchAuthSession. We have added a custom endpoint for the identity pool to the amplifyconfig and implemented a solution.
Issue #, if available
#11275
Description of how you validated changes
You built a custom app using Amplify and verified that you can access the AWS API Gateway URL you provided. AWS API Gateway referenced this URL.
https://aws.amazon.com/jp/blogs/architecture/enriching-amazon-cognito-features-with-an-amazon-api-gateway-proxy/
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.