-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): list API to accept both prefix and path #13100
Merged
Samaritan1011001
merged 62 commits into
aws-amplify:gen2-storage
from
Samaritan1011001:feat/list-remove-gen2
Mar 26, 2024
Merged
feat(storage): list API to accept both prefix and path #13100
Samaritan1011001
merged 62 commits into
aws-amplify:gen2-storage
from
Samaritan1011001:feat/list-remove-gen2
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/gen2-downloadData
ashika112
requested changes
Mar 12, 2024
ashika112
reviewed
Mar 12, 2024
ashika112
reviewed
Mar 12, 2024
jimblanc
previously approved these changes
Mar 25, 2024
ashika112
reviewed
Mar 25, 2024
jimblanc
reviewed
Mar 25, 2024
packages/storage/src/providers/s3/utils/validateStorageOperationInputWithPrefix.ts
Outdated
Show resolved
Hide resolved
ashwinkumar6
previously approved these changes
Mar 26, 2024
ashika112
previously approved these changes
Mar 26, 2024
jimblanc
previously approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM one small nit
Samaritan1011001
dismissed stale reviews from jimblanc, ashika112, and ashwinkumar6
via
March 26, 2024 22:11
9a827a7
ashwinkumar6
approved these changes
Mar 26, 2024
ashika112
approved these changes
Mar 26, 2024
jimblanc
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
List API will now accept either prefix or path as input. Depending on which is given, their respective types are suggested in the IDE and output has key or path respectively.
Some notes,
Below table shows the different type changes in
index.ts
.Note: None of the exposed type names have changed. Only the first two rows are the ones exposed via
aws-amplify/storage
.ListAllOutput, ListPaginateOutput
ListAllOutput, ListPaginateOutput
ListAllOptionsPath, ListPaginateOptionsPath
ListAllInputPath, ListPaginateInputPath,
ListAllInputPrefix,ListPaginateInputPrefix
ListAllOutput, ListPaginateOutput
ListAllOutputPrefix, ListAllOutputPath
ListPaginateOutputPath, ListPaginateOutputPrefix
Issue #, if available
Description of how you validated changes
Linked to a sample app and could complete the list operation both ways
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.