feat(storage): add path support to copy API #13104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar6
changed the title
ashwinkumar6
changed the title
ashwinkumar6
force-pushed
the
gen2-storage-copy
branch
2 times, most recently
from
3371ea9 to
511e83c
Compare
ashwinkumar6
force-pushed
the
gen2-storage-copy
branch
from
511e83c to
4d36d56
Compare
ashika112
reviewed
Mar 13, 2024
| ): Promise<CopyOutput> => { | ||
| ): Promise<CopyOutput> => | ||
| isCopyInputWithPath(input) | ||
| ? copyWithPath(amplify, input) |
There was a problem hiding this comment.
why not just directly call isInputWithPath?
There was a problem hiding this comment.
We could do something like isInputWithPath(input.source) but we need to narrow the input types because copyWithPath expects CopyInputPath and copyWithKey expects CopyInputKey
There was a problem hiding this comment.
I am thinking if we can use it and just cast as needed. i am wondering if there is any benefit to this approach over that
kvramyasri7
reviewed
Mar 14, 2024
cshfang
reviewed
Mar 16, 2024
added 2 commits
March 18, 2024 15:32
cshfang
previously approved these changes
Mar 19, 2024
added 2 commits
March 19, 2024 14:27
ashika112
reviewed
Mar 20, 2024
added 2 commits
March 20, 2024 13:23
cshfang
approved these changes
Mar 20, 2024
Great work 🎉
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update copy API to support path
Description of how you valdated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.