Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove concurrency restriction on push-latest-release workflow #13145

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

jimblanc
Copy link
Contributor

@jimblanc jimblanc commented Mar 18, 2024

Description of changes

This hot-fix removes the concurrency restriction on the push-latest-release workflow, which is causing releases to be aborted when auto-generated commits are made by CI. This is happening due to the change made in #13095 which no longer skips CI entirely for these auto-generated commits. It also reverts the Publish commit for the most recent aborted release to prepare for the hot-fix.

Issue #, if available

Description of how you validated changes

  • Confirmed that the auto-generated commits with [skip release] are in fact being skipped (i.e. no risk of infinite loop)
  • Tested expected deployment in Verdaccio using publish:release

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc force-pushed the hot-fix/release-automation branch from 233af3f to 0d0873e Compare March 18, 2024 23:28
@jimblanc jimblanc changed the title hot-fix: Revert release workflow changes hot-fix: Remove concurrency restriction on push-latest-release workflow Mar 18, 2024
@jimblanc jimblanc marked this pull request as ready for review March 18, 2024 23:33
@jimblanc jimblanc requested review from a team as code owners March 18, 2024 23:33
@jimblanc jimblanc changed the title hot-fix: Remove concurrency restriction on push-latest-release workflow chore: Remove concurrency restriction on push-latest-release workflow Mar 18, 2024
ashwinkumar6
ashwinkumar6 previously approved these changes Mar 18, 2024
Copy link
Member

@ashwinkumar6 ashwinkumar6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimblanc jimblanc force-pushed the hot-fix/release-automation branch 2 times, most recently from 8d16377 to 16fd42e Compare March 19, 2024 00:05
ashwinkumar6
ashwinkumar6 previously approved these changes Mar 19, 2024
@jimblanc jimblanc merged commit 75ae2af into aws-amplify:release Mar 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants