-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove concurrency restriction on push-latest-release
workflow
#13145
Merged
jimblanc
merged 3 commits into
aws-amplify:release
from
jimblanc:hot-fix/release-automation
Mar 19, 2024
Merged
chore: Remove concurrency restriction on push-latest-release
workflow
#13145
jimblanc
merged 3 commits into
aws-amplify:release
from
jimblanc:hot-fix/release-automation
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
233af3f
to
0d0873e
Compare
push-latest-release
workflow
push-latest-release
workflowpush-latest-release
workflow
ashwinkumar6
previously approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
8d16377
to
16fd42e
Compare
ashwinkumar6
previously approved these changes
Mar 19, 2024
elorzafe
reviewed
Mar 19, 2024
elorzafe
reviewed
Mar 19, 2024
elorzafe
reviewed
Mar 19, 2024
elorzafe
reviewed
Mar 19, 2024
elorzafe
reviewed
Mar 19, 2024
elorzafe
reviewed
Mar 19, 2024
…r, and react-native.
16fd42e
to
b37cc16
Compare
elorzafe
approved these changes
Mar 19, 2024
ashwinkumar6
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This hot-fix removes the concurrency restriction on the
push-latest-release
workflow, which is causing releases to be aborted when auto-generated commits are made by CI. This is happening due to the change made in #13095 which no longer skips CI entirely for these auto-generated commits. It also reverts thePublish
commit for the most recent aborted release to prepare for the hot-fix.Issue #, if available
Description of how you validated changes
[skip release]
are in fact being skipped (i.e. no risk of infinite loop)publish:release
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.