Update Path assertion #13160
Merged
Update Path assertion #13160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/storage/__tests__/providers/s3/apis/utils/validateStorageOperationInput.test.ts
Outdated
Show resolved
Hide resolved
ashwinkumar6
previously approved these changes
Mar 21, 2024
Co-authored-by: Ashwin Kumar <ashwinkumar2468@gmail.com>
jimblanc
approved these changes
Mar 21, 2024
Samaritan1011001
approved these changes
Mar 21, 2024
| @@ -218,11 +218,11 @@ describe('downloadData with path', () => { | |||
|
|
|||
| test.each([ | |||
| { | |||
| path: '/path', | |||
| path: 'path', | |||
| expectedKey: 'path', | |||
There was a problem hiding this comment.
why have expectedPath, can just have the path in this object
There was a problem hiding this comment.
just for readability and consistency.
packages/storage/__tests__/providers/s3/apis/utils/validateStorageOperationInput.test.ts
Show resolved
Hide resolved
ashwinkumar6
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
pathto not start with leading slashDescription of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.