Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lerna package bump issue #13228

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ashwinkumar6
Copy link
Member

@ashwinkumar6 ashwinkumar6 commented Apr 9, 2024

Description of changes

Current behavior

Expected behavior

  • Lerna only bumps the version of the packages that are changed and their dependent packages
  • Example a feat commit on auth causes a minor version bump on auth, patch version bump on aws-amplify
    (auth is a dependency in aws-amplify)

Fix

before lerna publish checkout with fetch-depth: 0see Lerna issue on GH actions

Description of how you validated changes

Current behavior
(all packages get a patch bump irrespective of files changed)

lerna info Assuming all packages changed
lerna info getChangelogConfig Successfully resolved preset "conventional-changelog-angular"

lerna info auto-confirmed 
Changes:
lerna info execute Skipping releases
 - @aws-amplify/adapter-nextjs: 1.0.22 => 1.0.23
 - @aws-amplify/analytics: 7.0.22 => 7.0.23
 - @aws-amplify/api: 6.0.22 => 6.0.23
 - @aws-amplify/api-graphql: 4.0.22 => 4.0.23
 - @aws-amplify/api-rest: 4.0.22 => 4.0.23
 - @aws-amplify/auth: 6.0.22 => 6.0.23
 - aws-amplify: 6.0.22 => 6.0.23
 - @aws-amplify/core: 6.0.22 => 6.0.23
 - @aws-amplify/datastore: 5.0.22 => 5.0.23
 - @aws-amplify/datastore-storage-adapter: 2.1.22 => 2.1.23
 - @aws-amplify/geo: 3.0.22 => 3.0.23
 - @aws-amplify/interactions: 6.0.22 => 6.0.23
 - @aws-amplify/notifications: 2.0.22 => 2.0.23
 - @aws-amplify/predictions: 6.0.22 => 6.0.23
 - @aws-amplify/pubsub: 6.0.22 => 6.0.23
 - @aws-amplify/react-native: 1.0.23 => 1.0.24
 - @aws-amplify/react-native-example: 0.0.23 => 0.0.24 (private)
 - @aws-amplify/rtn-push-notification: 1.2.23 => 1.2.24
 - @aws-amplify/rtn-web-browser: 1.0.23 => 1.0.24
 - @aws-amplify/storage: 6.0.22 => 6.0.23
 - tsc-compliance-test: 0.1.22 => 0.1.23 (private)

Behavior after fix
(a feat commit on storage)

lerna info Looking for changed packages since @aws-amplify/auth@6.2.0
lerna info getChangelogConfig Successfully resolved preset "conventional-changelog-angular"
Changes:
lerna info auto-confirmed 
 - @aws-amplify/adapter-nextjs: 1.1.2 => 1.1.3
 - aws-amplify: 6.1.2 => 6.1.3
 - @aws-amplify/predictions: 6.1.1 => 6.1.2
 - @aws-amplify/storage: 6.2.0 => 6.3.0
 - tsc-compliance-test: 0.2.2 => 0.2.3 (private)

storage get's a minor bump and other dependent packages get a patch version bump

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashwinkumar6 ashwinkumar6 requested a review from a team as a code owner April 9, 2024 15:59
@ashwinkumar6 ashwinkumar6 merged commit c4cd66d into aws-amplify:main Apr 9, 2024
31 checks passed
@ashwinkumar6 ashwinkumar6 deleted the v6-lerna-fix branch April 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants