Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump package versions #13254

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

ashwinkumar6
Copy link
Member

@ashwinkumar6 ashwinkumar6 commented Apr 16, 2024

Description of changes

The following package versions are deprecated. This PR updates the versions of these packages to their latest deprecated versions. Lerna would then bump these to their next patch version going past the deprecated versions. This would help us avoid chances of conflicting with these deprecated versions during release.

s.no package versions deprecated
1 @aws-amplify/adapter-nextjs 1.1.1, 1.1.2, 1.1.3
2 @aws-amplify/auth 6.2.0
3 @aws-amplify/pubsub 6.1.1
4 aws-amplify 6.1.1, 6.1.2, 6.1.3
5 @aws-amplify/predictions 6.1.1, 6.1.2
6 @aws-amplify/storage 6.2.0, 6.3.0

Steps to take during release (optional)
1. create and push tags for the same version to remote

git tag @aws-amplify/adapter-nextjs@1.1.3 && git tag @aws-amplify/auth@6.2.0 && git tag @aws-amplify/pubsub@6.1.1 && git tag aws-amplify@6.1.3 && git tag @aws-amplify/predictions@6.1.2 && git tag @aws-amplify/storage@6.3.0 && git push origin @aws-amplify/adapter-nextjs@1.1.3 @aws-amplify/auth@6.2.0 @aws-amplify/pubsub@6.1.1 aws-amplify@6.1.3 @aws-amplify/predictions@6.1.2 @aws-amplify/storage@6.3.0

2. release as usual

Description of how you validated changes

Tested locally using verdaccio
Changes Detected

Changes:
 - @aws-amplify/adapter-nextjs: 1.1.3 => 1.1.4
 - @aws-amplify/analytics: 7.0.28 => 7.0.29
 - @aws-amplify/api: 6.0.29 => 6.0.30
 - @aws-amplify/api-graphql: 4.0.29 => 4.0.30
 - @aws-amplify/api-rest: 4.0.28 => 4.0.29
 - @aws-amplify/auth: 6.2.0 => 6.2.1
 - aws-amplify: 6.1.3 => 6.1.4
 - @aws-amplify/core: 6.0.28 => 6.0.29
 - @aws-amplify/datastore: 5.0.29 => 5.0.30
 - @aws-amplify/datastore-storage-adapter: 2.1.29 => 2.1.30
 - @aws-amplify/geo: 3.0.28 => 3.0.29
 - @aws-amplify/interactions: 6.0.28 => 6.0.29
 - @aws-amplify/notifications: 2.0.28 => 2.0.29
 - @aws-amplify/predictions: 6.1.2 => 6.1.3
 - @aws-amplify/pubsub: 6.1.1 => 6.1.2
 - @aws-amplify/react-native: 1.0.28 => 1.0.29
 - @aws-amplify/react-native-example: 0.0.28 => 0.0.29 (private)
 - @aws-amplify/rtn-push-notification: 1.2.28 => 1.2.29
 - @aws-amplify/rtn-web-browser: 1.0.28 => 1.0.29
 - @aws-amplify/storage: 6.3.0 => 6.3.1
 - tsc-compliance-test: 0.1.30 => 0.1.31 (private)

Packages Published

Successfully published:
 - @aws-amplify/adapter-nextjs@1.1.4
 - @aws-amplify/analytics@7.0.29
 - @aws-amplify/api@6.0.30
 - @aws-amplify/api-graphql@4.0.30
 - @aws-amplify/api-rest@4.0.29
 - @aws-amplify/auth@6.2.1
 - @aws-amplify/core@6.0.29
 - @aws-amplify/datastore@5.0.30
 - @aws-amplify/datastore-storage-adapter@2.1.30
 - @aws-amplify/geo@3.0.29
 - @aws-amplify/interactions@6.0.29
 - @aws-amplify/notifications@2.0.29
 - @aws-amplify/predictions@6.1.3
 - @aws-amplify/pubsub@6.1.2
 - @aws-amplify/react-native@1.0.29
 - @aws-amplify/rtn-push-notification@1.2.29
 - @aws-amplify/rtn-web-browser@1.0.29
 - @aws-amplify/storage@6.3.1
 - aws-amplify@6.1.4
lerna success published 19 packages

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashwinkumar6 ashwinkumar6 requested review from a team as code owners April 16, 2024 17:31
ashika112
ashika112 previously approved these changes Apr 16, 2024
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense to me, thanks! I'm curious if we can remove the manual tagging step in the description though, could you confirm if it's required?

@ashwinkumar6 ashwinkumar6 requested a review from a team as a code owner April 17, 2024 17:59
@ashwinkumar6 ashwinkumar6 force-pushed the bump-package-versions branch 2 times, most recently from 80a3a26 to 990f451 Compare April 17, 2024 18:26
@ashwinkumar6
Copy link
Member Author

ashwinkumar6 commented Apr 17, 2024

I'm curious if we can remove the manual tagging step in the description though, could you confirm if it's required?

Thanks @jimblanc, verified that this is an optional step and can be skipped. The packages published are the same without performing this manual step.

The only difference is, lerna only creates and pushes tags for the new packages it's publishing. So this old tags (example aws-amplify@6.1.3 won't exist, aws-amplify@6.1.4 will exist)

jimblanc
jimblanc previously approved these changes Apr 17, 2024
jimblanc
jimblanc previously approved these changes Apr 24, 2024
@ashwinkumar6 ashwinkumar6 merged commit aa490b9 into aws-amplify:main Apr 25, 2024
30 checks passed
@ashwinkumar6 ashwinkumar6 deleted the bump-package-versions branch April 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants