-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gh-actions): gen2 e2e rest api #13293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samaritan1011001
force-pushed
the
feat/rest-gen2
branch
from
April 29, 2024 20:23
5469c9e
to
2c51dde
Compare
Samaritan1011001
changed the title
feat(github-actions): gen2 e2e rest api
feat(gh-actions): gen2 e2e rest api
Apr 29, 2024
Samaritan1011001
force-pushed
the
feat/rest-gen2
branch
2 times, most recently
from
April 29, 2024 21:04
ddf2f1e
to
701d428
Compare
Samaritan1011001
force-pushed
the
feat/rest-gen2
branch
from
April 30, 2024 17:31
701d428
to
6af3a13
Compare
israx
reviewed
May 1, 2024
jimblanc
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending Israel's suggestion & removal of the pre-id branch
israx
approved these changes
May 2, 2024
ashika112
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates GH actions to take in additional
backend
parameter and call the sample staging app with it.Subsequent tests that need to be added for Gen2 only needs to add a new test case with the value
backend: gen2
similar to what's shown here.Issue #, if available
Description of how you validated changes
Passing GH actions on this branch.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.