-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update macos version to latest #13350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samaritan1011001
commented
May 9, 2024
jimblanc
reviewed
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will approve once testing change reverted
ashika112
reviewed
May 10, 2024
ashika112
approved these changes
May 13, 2024
ashwinkumar6
approved these changes
May 14, 2024
jimblanc
approved these changes
May 14, 2024
HuiSF
pushed a commit
that referenced
this pull request
May 16, 2024
* chore: pin to use macos 12 in gh actions * test actions * chore: use macos latest and iphone 15 * chore: revert custom branch name * chore: revert integ test changes --------- Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
jimblanc
pushed a commit
that referenced
this pull request
May 16, 2024
chore: update macos version to latest (#13350) * chore: pin to use macos 12 in gh actions * test actions * chore: use macos latest and iphone 15 * chore: revert custom branch name * chore: revert integ test changes --------- Co-authored-by: ManojNB <manojnb@amazon.com> Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, prereq: https://github.com/aws-amplify/amplify-js-samples-staging/pull/859
Description of changes
Reverts the macos version to latest. This needs to be merged after the staging repo PR so the detox upgrade is in.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.