fix(ssr-adapter): refreshToken may return the same tokens across requests #13387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the server side
HuiSF
force-pushed
the
hui/fix/patch-ssr-regression
branch
from
1283b78 to
4ce42e7
Compare
cshfang
reviewed
May 15, 2024
| @@ -77,3 +77,4 @@ const refreshAuthTokensFunction: TokenRefresher = async ({ | |||
| }; | |||
|
|
|||
| export const refreshAuthTokens = deDupeAsyncFunction(refreshAuthTokensFunction); | |||
| export const refreshAuthTokensWithoutDedupe = refreshAuthTokensFunction; | |||
There was a problem hiding this comment.
Nit: Just rename refreshAuthTokensFunction -> refreshAuthTokensWithoutDedupe and export it
There was a problem hiding this comment.
Will do this later, as I'm thinking of a different solution to create dedupe edition for SSR use cases.
jimblanc
reviewed
May 15, 2024
HuiSF
force-pushed
the
hui/fix/patch-ssr-regression
branch
from
4ce42e7 to
432638d
Compare
jimblanc
approved these changes
May 15, 2024
cshfang
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
getServerSidePropscontext, refresh tokens were not being sent back to client cookie storeIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.