Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Enable resumable SignIn #13483

Merged
merged 55 commits into from
Sep 23, 2024

Conversation

joon-won
Copy link
Member

@joon-won joon-won commented Jun 7, 2024

Description of changes

  • Enable v6 users to have an option to continue SignIn process after a full browser reload by storing, then utilizing session in session storage

Issue #, if available

Description of how you validated changes

  • Unit tests (IP)
  • Smoke Test on sample application

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@israx israx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joon-won . We are getting close. A couple of things,

  1. we should consider creating an internal sync sessionStorage util so we don't have to change the sync behavior of the signInStore

  2. we must avoid modifying state at all costs. Left comments bellow and pointed out the tests needed

@joon-won joon-won marked this pull request as ready for review June 20, 2024 20:50
@joon-won joon-won merged commit f3421f1 into aws-amplify:main Sep 23, 2024
30 checks passed
joon-won added a commit that referenced this pull request Sep 26, 2024
joon-won added a commit that referenced this pull request Sep 26, 2024
Revert "feat(auth): Enable resumable SignIn (#13483)"

This reverts commit f3421f1.
@aca-stev
Copy link

Hi, I noticed this PR was previously merged but later reverted. Could you share why it was reverted and if there are plans to re-integrate? Thanks!

@joon-won
Copy link
Member Author

Hey @aca-stev, this PR was previously reverted due to our internal plan change. This is now re-released with Amplify JS 6.11.0, please feel free to reach out if you have any further questions or concerns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants