-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Enable resumable SignIn #13483
feat(auth): Enable resumable SignIn #13483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joon-won . We are getting close. A couple of things,
-
we should consider creating an internal sync
sessionStorage
util so we don't have to change the sync behavior of thesignInStore
-
we must avoid modifying state at all costs. Left comments bellow and pointed out the tests needed
Hi, I noticed this PR was previously merged but later reverted. Could you share why it was reverted and if there are plans to re-integrate? Thanks! |
Hey @aca-stev, this PR was previously reverted due to our internal plan change. This is now re-released with Amplify JS 6.11.0, please feel free to reach out if you have any further questions or concerns! |
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.