Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-bucket] fix - disable firefox browser test for nextjs auth #13653

Merged

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Jul 29, 2024

Description of changes

The purpose of this pull request is to disable the firefox Next.js storage integration test. There exists several issues between Firefox and Cypress that cause issues when testing using secure cookies (which are required in the Next.js context). These issues can be mitigated locally but not in CI without additional effort.

Failing on Firefox and succeeding on Chrome in CI.
https://github.com/jjarvisp/amplify-js/actions/runs/10113370892

Cypress / Firefox issues:
cypress-io/cypress#18690
cypress-io/cypress#18217

Issue #, if available

Description of how you validated changes

https://github.com/jjarvisp/amplify-js/actions/runs/10148754990

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jjarvisp jjarvisp requested a review from a team as a code owner July 29, 2024 17:42
@jjarvisp jjarvisp merged commit 56a2acd into aws-amplify:feat/multi-bucket Jul 30, 2024
28 checks passed
@jjarvisp jjarvisp deleted the fix/disable-next-firefox branch July 30, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants