fix(adapter-nextjs): create jwt verifier once #13825
Merged
+199
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
requested review from
sktimalsina,
cshfang,
HuiSF and
pranavosu
as code owners
HuiSF
previously approved these changes
Dec 12, 2024
jjarvisp
previously approved these changes
Dec 12, 2024
HuiSF
changed the title
ashwinkumar6
previously approved these changes
Dec 12, 2024
packages/adapter-nextjs/__tests__/utils/isValidCognitoToken.test.ts
Outdated
Show resolved
Hide resolved
cshfang
dismissed stale reviews from ashwinkumar6, jjarvisp, and HuiSF
via
fa12437
ashwinkumar6
approved these changes
Dec 12, 2024
jjarvisp
approved these changes
Dec 12, 2024
HuiSF
approved these changes
Dec 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Creates the token JWT verifier during the createServerRunner process and stores in memory instead of on getItem. This allows us to maintain the JWKS in cache instead of calling the JWKS endpoint every time tokens are retrieved from localStorage.
Issue #, if available
#13706
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.