Storage Browser Default Auth #13866
Merged
Storage Browser Default Auth #13866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashika112
requested review from
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
ashika112
commented
Oct 4, 2024
There was a problem hiding this comment.
Adapter will most likely be moved to UI
ashika112
commented
Oct 4, 2024
There was a problem hiding this comment.
Adapter will most likely be moved to UI
AllanZhengYP
reviewed
Oct 8, 2024
packages/storage/src/internals/amplifyAuthConfigAdapter/createAmplifyListLocationsHandler.ts
Show resolved
Hide resolved
packages/storage/src/internals/amplifyAuthConfigAdapter/createAmplifyListLocationsHandler.ts
Outdated
Show resolved
Hide resolved
packages/storage/src/internals/amplifyAuthConfigAdapter/generateLocationsFromPaths.ts
Outdated
Show resolved
Hide resolved
packages/storage/src/internals/amplifyAuthConfigAdapter/generateLocationsFromPaths.ts
Outdated
Show resolved
Hide resolved
packages/storage/src/internals/amplifyAuthConfigAdapter/generateLocationsFromPaths.ts
Outdated
Show resolved
Hide resolved
…plify-js into feat/sb-default-auth
ashika112
commented
Oct 16, 2024
| /** | ||
| * @internal | ||
| */ | ||
| export interface PathAccess { |
There was a problem hiding this comment.
Keeping this separate for now. In a separate PR will align this and managed Auth Location access into one.
| @@ -50,6 +50,8 @@ export interface AmplifyOutputsStorageBucketProperties { | |||
| bucket_name: string; | |||
| /** Region for the bucket */ | |||
| aws_region: string; | |||
| /** Paths to object with access permissions */ | |||
| paths?: Record<string, Record<string, string[] | undefined>>; | |||
There was a problem hiding this comment.
The in-line type is a bit hard the follow, what about using a interface with property names:
type Permission = string;
interface StorageBucketPaths {
[pathPrefix: string]: {
[accessType: string]: Permission[] | undefined;
}
}There was a problem hiding this comment.
Our ESLint does not allow for index signature. But i think we can create alias and align if we want. I can look into this in my follow up PR for pagination if there are no other comments :)
AllanZhengYP
approved these changes
Oct 17, 2024
packages/storage/src/internals/amplifyAuthConfigAdapter/createAmplifyAuthConfigAdapter.ts
Show resolved
Hide resolved
calebpollman
approved these changes
Oct 18, 2024
ashika112
merged commit e515d24
into
aws-amplify:storage-browser/integrity
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
TODO
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.