Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix dts bundler config #13884

Merged
merged 1 commit into from
Oct 5, 2024
Merged

chore: fix dts bundler config #13884

merged 1 commit into from
Oct 5, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Oct 3, 2024

Description of changes

  • The tsconfig.json path has changed while migrating eslint, and the ds bundler didn't get a corresponding update.
  • Also fixes the sdk.ts file name in the Auth package

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner October 3, 2024 21:14
jimblanc
jimblanc approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuiSF HuiSF merged commit 93f0536 into main Oct 5, 2024
31 checks passed
@HuiSF HuiSF deleted the hui/chore/ds-bundler-auth-path branch October 5, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjarvisp jjarvisp jjarvisp approved these changes

@ashika112 ashika112 ashika112 approved these changes

@ashwinkumar6 ashwinkumar6 ashwinkumar6 approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@jimblanc jimblanc jimblanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HuiSF @jimblanc @AllanZhengYP @ashwinkumar6 @ashika112 @jjarvisp